fix: Fixed romm login, now uses token
feat: Moved romm to internal plugin fix: Made focusing and navigation more reliable fix: Loading errors on first time launch
This commit is contained in:
parent
7c10f4e4c2
commit
816d50ae4d
81 changed files with 1659 additions and 1097 deletions
|
|
@ -1,11 +1,8 @@
|
|||
import z from "zod";
|
||||
import { IJob, JobContext } from "../task-queue";
|
||||
import { CACHE_KEYS, getOrCached } from "../cache";
|
||||
import { config } from "../app";
|
||||
import { getPlatformFirmwareApiFirmwareGet, getPlatformsApiPlatformsGet } from "@/clients/romm";
|
||||
import fs from 'node:fs/promises';
|
||||
import { hashFile, simulateProgress } from "@/bun/utils";
|
||||
import { Downloader, FileEntry } from "@/bun/utils/downloader";
|
||||
import { config, plugins } from "../app";
|
||||
import { simulateProgress } from "@/bun/utils";
|
||||
import { Downloader } from "@/bun/utils/downloader";
|
||||
import path from 'node:path';
|
||||
import { ensureDir } from "fs-extra";
|
||||
import { buildStoreFrontendEmulatorSystems, getStoreEmulatorPackage } from "../store/services/gamesService";
|
||||
|
|
@ -27,46 +24,27 @@ export class BiosDownloadJob implements IJob<z.infer<typeof BiosDownloadJob.data
|
|||
|
||||
async start (context: JobContext<IJob<never, "download">, never, "download">)
|
||||
{
|
||||
const allRommPlatforms = await getOrCached(CACHE_KEYS.ROM_PLATFORMS, () => getPlatformsApiPlatformsGet({ throwOnError: true }), { expireMs: 60 * 60 * 1000 }).then(d => d.data);
|
||||
|
||||
const emulator = await getStoreEmulatorPackage(this.emulator);
|
||||
if (!emulator) throw new Error("Could Not Find Emulator");
|
||||
|
||||
const systems = await buildStoreFrontendEmulatorSystems(emulator);
|
||||
|
||||
const biosFolder = path.join(config.get('downloadPath'), "bios", this.emulator);
|
||||
await ensureDir(biosFolder);
|
||||
const rommPlatforms = systems.filter(s => s.romm_slug).map(s => allRommPlatforms.find(p => p.slug == s.romm_slug)).filter(r => !!r);
|
||||
const files = await plugins.hooks.emulators.fetchBiosDownload.promise({ emulator: this.emulator, systems, biosFolder });
|
||||
|
||||
const firmwaresToDownload: FileEntry[] = [];
|
||||
|
||||
for (const rommPlatform of rommPlatforms)
|
||||
{
|
||||
const firmwares = await getPlatformFirmwareApiFirmwareGet({ query: { platform_id: rommPlatform.id } }).then(d => d.data);
|
||||
if (firmwares)
|
||||
{
|
||||
for (const firmware of firmwares)
|
||||
{
|
||||
const firmwarePath = path.join(biosFolder, firmware.file_name);
|
||||
const exists = await fs.exists(firmwarePath);
|
||||
|
||||
if (exists && await hashFile(firmwarePath, 'sha1'))
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
firmwaresToDownload.push({ file_name: firmware.file_name, file_path: '', url: new URL(`http://romm.simeonradivoev.com/api/firmware/${firmware.id}/content/${encodeURIComponent(firmware.file_name)}`) });
|
||||
}
|
||||
}
|
||||
}
|
||||
if (!files) throw new Error("Could not find source to download from");
|
||||
|
||||
if (this.dryRun)
|
||||
{
|
||||
await simulateProgress((p) => context.setProgress(p, 'download'), context.abortSignal);
|
||||
} else
|
||||
{
|
||||
const downloader = new Downloader('bios-download', firmwaresToDownload, biosFolder, {
|
||||
const headers: Record<string, string> = {};
|
||||
if (files.auth)
|
||||
headers['Authorization'] = files.auth;
|
||||
|
||||
const downloader = new Downloader('bios-download', files.files, biosFolder, {
|
||||
signal: context.abortSignal,
|
||||
headers,
|
||||
onProgress (stats)
|
||||
{
|
||||
context.setProgress(stats.progress, "download");
|
||||
|
|
@ -75,7 +53,6 @@ export class BiosDownloadJob implements IJob<z.infer<typeof BiosDownloadJob.data
|
|||
|
||||
await downloader.start();
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
exposeData ()
|
||||
|
|
|
|||
|
|
@ -5,15 +5,17 @@ import fs from 'node:fs/promises';
|
|||
import * as schema from "@schema/app";
|
||||
import * as emulatorSchema from "@schema/emulators";
|
||||
import path from 'node:path';
|
||||
import { getPlatformApiPlatformsIdGet, getRomApiRomsIdGet, PlatformSchema } from "@clients/romm";
|
||||
import { config, db, emulatorsDb, events } from "../app";
|
||||
import { config, db, emulatorsDb, events, plugins } from "../app";
|
||||
import { extractStoreGameSourceId, getStoreGameFromId } from "../store/services/gamesService";
|
||||
import * as igdb from 'ts-igdb-client';
|
||||
import secrets from "../secrets";
|
||||
import { hashFile, simulateProgress } from "@/bun/utils";
|
||||
import { simulateProgress } from "@/bun/utils";
|
||||
import { Downloader } from "@/bun/utils/downloader";
|
||||
import _7z from '7zip-min';
|
||||
import z from "zod";
|
||||
import { checkFiles } from "../games/services/utils";
|
||||
import { ensureDir } from "fs-extra";
|
||||
import { getAuthToken } from "@/clients/romm/core/auth.gen";
|
||||
|
||||
interface JobConfig
|
||||
{
|
||||
|
|
@ -30,16 +32,14 @@ export class InstallJob implements IJob<never, InstallJobStates>
|
|||
static dataSchema = z.never();
|
||||
public gameId: string;
|
||||
public source: string;
|
||||
public sourceId: string;
|
||||
public config?: JobConfig;
|
||||
|
||||
public group = InstallJob.id;
|
||||
|
||||
constructor(id: string, source: string, sourceId: string, config?: JobConfig)
|
||||
constructor(id: string, source: string, config?: JobConfig)
|
||||
{
|
||||
this.gameId = id;
|
||||
this.config = config;
|
||||
this.sourceId = sourceId;
|
||||
this.source = source;
|
||||
}
|
||||
|
||||
|
|
@ -49,102 +49,53 @@ export class InstallJob implements IJob<never, InstallJobStates>
|
|||
fs.mkdir(config.get('downloadPath'), { recursive: true });
|
||||
|
||||
const downloadPath = config.get('downloadPath');
|
||||
|
||||
let files: {
|
||||
url: URL,
|
||||
file_path: string;
|
||||
file_name: string;
|
||||
size?: number;
|
||||
}[] = [];
|
||||
let screenshotUrls: string[];
|
||||
let coverUrl: string;
|
||||
let rommPlatform: PlatformSchema | undefined;
|
||||
let slug: string | null;
|
||||
let path_fs: string | undefined;
|
||||
let summary: string | null;
|
||||
let name: string | null;
|
||||
let last_played: Date | null;
|
||||
let igdb_id: number | null;
|
||||
let ra_id: number | null;
|
||||
let source_id: string;
|
||||
let system_slug: string;
|
||||
let extract_path: string;
|
||||
let metadata: any | undefined;
|
||||
let info: DownloadInfo | undefined;
|
||||
|
||||
switch (this.source)
|
||||
{
|
||||
case 'romm':
|
||||
|
||||
const rom = (await getRomApiRomsIdGet({ path: { id: Number(this.gameId) }, throwOnError: true })).data;
|
||||
rommPlatform = (await getPlatformApiPlatformsIdGet({ path: { id: rom.platform_id }, throwOnError: true })).data;
|
||||
|
||||
const rommAddress = config.get('rommAddress');
|
||||
coverUrl = `${rommAddress}${rom.path_cover_large}`;
|
||||
screenshotUrls = rom.merged_screenshots.map(s => `${config.get('rommAddress')}${s}`);
|
||||
last_played = rom.rom_user.last_played ? new Date(rom.rom_user.last_played) : null;
|
||||
igdb_id = rom.igdb_id;
|
||||
ra_id = rom.ra_id;
|
||||
summary = rom.summary;
|
||||
name = rom.name;
|
||||
path_fs = path.join(rom.fs_path, rom.fs_name);
|
||||
source_id = String(rom.id);
|
||||
slug = rom.slug;
|
||||
system_slug = rommPlatform.slug;
|
||||
extract_path = '';
|
||||
metadata = rom.metadatum;
|
||||
|
||||
const rommFiles = await Promise.all(rom.files.map(async f =>
|
||||
{
|
||||
const localPath = path.join(config.get('downloadPath'), f.full_path);
|
||||
if (f.md5_hash && await fs.exists(localPath))
|
||||
{
|
||||
const existingHash = await hashFile(localPath, 'sha1');
|
||||
if (existingHash === f.md5_hash)
|
||||
{
|
||||
console.log("File Already Present: ", f.full_path);
|
||||
return undefined;
|
||||
}
|
||||
|
||||
console.warn("File ", f.full_path, 'with hash', existingHash, 'has different hash than', f.sha1_hash);
|
||||
}
|
||||
|
||||
return {
|
||||
url: new URL(`${config.get('rommAddress')}/api/romsfiles/${f.id}/content/${f.file_name}`),
|
||||
file_name: f.file_name,
|
||||
file_path: path.join(config.get('downloadPath'), f.file_path),
|
||||
size: f.file_size_bytes
|
||||
};
|
||||
}));
|
||||
|
||||
files.push(...rommFiles.filter(f => f !== undefined));
|
||||
break;
|
||||
case 'store':
|
||||
const game = await getStoreGameFromId(this.gameId);
|
||||
const gameId = extractStoreGameSourceId(this.gameId);
|
||||
coverUrl = game.pictures.titlescreens[0];
|
||||
screenshotUrls = game.pictures.screenshots;
|
||||
files.push({ url: new URL(game.file), file_path: `roms/${game.system}`, file_name: path.basename(decodeURI(game.file)) });
|
||||
slug = this.gameId;
|
||||
source_id = this.gameId;
|
||||
name = game.title;
|
||||
summary = game.description;
|
||||
system_slug = gameId.system;
|
||||
extract_path = path.join('roms', gameId.system);
|
||||
info = {
|
||||
coverUrl: game.pictures.titlescreens[0],
|
||||
screenshotUrls: game.pictures.screenshots,
|
||||
files: [{
|
||||
url: new URL(game.file),
|
||||
file_path: `roms/${game.system}`,
|
||||
file_name: path.basename(decodeURI(game.file)),
|
||||
size: 0
|
||||
}],
|
||||
slug: this.gameId,
|
||||
source_id: this.gameId,
|
||||
name: game.title,
|
||||
summary: game.description,
|
||||
system_slug: gameId.system,
|
||||
extract_path: path.join('roms', gameId.system),
|
||||
};
|
||||
|
||||
break;
|
||||
default:
|
||||
throw new Error("Unsupported source");
|
||||
info = await plugins.hooks.games.fetchDownloads.promise({ source: this.source, id: this.gameId });
|
||||
break;
|
||||
}
|
||||
|
||||
if (!info) throw new Error(`Could not find downloader for source ${this.source}`);
|
||||
|
||||
const files = await checkFiles(info.files, !!info.extract_path);
|
||||
|
||||
if (this.config?.dryRun !== true)
|
||||
{
|
||||
if (this.config?.dryDownload !== true)
|
||||
if (this.config?.dryDownload !== true && files.some(f => !f.exists || !f.matches))
|
||||
{
|
||||
const headers: Record<string, string> = {};
|
||||
if (info.auth)
|
||||
headers['Authorization'] = info.auth;
|
||||
const downloader = new Downloader(`game-${this.source}-${this.gameId}`,
|
||||
files,
|
||||
files.filter(f => !f.exists || !f.matches),
|
||||
config.get('downloadPath'),
|
||||
{
|
||||
signal: cx.abortSignal,
|
||||
headers,
|
||||
onProgress (stats)
|
||||
{
|
||||
cx.setProgress(stats.progress, 'download');
|
||||
|
|
@ -152,21 +103,21 @@ export class InstallJob implements IJob<never, InstallJobStates>
|
|||
});
|
||||
|
||||
const downloadedFiles = await downloader.start();
|
||||
if (extract_path && downloadedFiles)
|
||||
if (info.extract_path && downloadedFiles)
|
||||
{
|
||||
for (const path of downloadedFiles)
|
||||
{
|
||||
await _7z.unpack(path, extract_path);
|
||||
await _7z.unpack(path, info.extract_path);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
if (this.config?.dryDownload === true)
|
||||
if (this.config?.dryDownload === true && info.extract_path)
|
||||
{
|
||||
await mkdir(path.join(downloadPath, extract_path), { recursive: true });
|
||||
await ensureDir(path.join(downloadPath, info.extract_path));
|
||||
}
|
||||
|
||||
const coverResponse = await fetch(coverUrl);
|
||||
const coverResponse = await fetch(info.coverUrl);
|
||||
const cover = Buffer.from(await coverResponse.arrayBuffer());
|
||||
|
||||
if (cx.abortSignal.aborted) return;
|
||||
|
|
@ -174,18 +125,18 @@ export class InstallJob implements IJob<never, InstallJobStates>
|
|||
await db.transaction(async (tx) =>
|
||||
{
|
||||
// Search for existing platform
|
||||
const platformSearch = [eq(schema.platforms.slug, system_slug)];
|
||||
const esPlatformSearch = [eq(emulatorSchema.systemMappings.system, system_slug)];
|
||||
const platformSearch = [eq(schema.platforms.slug, info.system_slug)];
|
||||
const esPlatformSearch = [eq(emulatorSchema.systemMappings.system, info.system_slug)];
|
||||
|
||||
if (rommPlatform)
|
||||
if (info.platform)
|
||||
{
|
||||
if (rommPlatform.igdb_id) platformSearch.push(eq(schema.platforms.igdb_id, rommPlatform.igdb_id));
|
||||
if (rommPlatform.igdb_slug) platformSearch.push(eq(schema.platforms.igdb_slug, rommPlatform.igdb_slug));
|
||||
if (rommPlatform.ra_id) platformSearch.push(eq(schema.platforms.ra_id, rommPlatform.ra_id));
|
||||
if (rommPlatform.moby_id) platformSearch.push(eq(schema.platforms.moby_id, rommPlatform.moby_id));
|
||||
if (info.platform.igdb_id) platformSearch.push(eq(schema.platforms.igdb_id, info.platform.igdb_id));
|
||||
if (info.platform.igdb_slug) platformSearch.push(eq(schema.platforms.igdb_slug, info.platform.igdb_slug));
|
||||
if (info.platform.ra_id) platformSearch.push(eq(schema.platforms.ra_id, info.platform.ra_id));
|
||||
if (info.platform.moby_id) platformSearch.push(eq(schema.platforms.moby_id, info.platform.moby_id));
|
||||
|
||||
esPlatformSearch.push(eq(emulatorSchema.systemMappings.source, 'romm'));
|
||||
esPlatformSearch.push(eq(emulatorSchema.systemMappings.sourceSlug, rommPlatform.slug));
|
||||
esPlatformSearch.push(eq(emulatorSchema.systemMappings.sourceSlug, info.platform.slug));
|
||||
}
|
||||
|
||||
const esPlatform = await emulatorsDb.query.systemMappings.findFirst({
|
||||
|
|
@ -201,9 +152,9 @@ export class InstallJob implements IJob<never, InstallJobStates>
|
|||
if (!existingPlatform)
|
||||
{
|
||||
// TODO: use something else than the romm demo as CDN
|
||||
const platformCover = await fetch(`https://demo.romm.app/assets/platforms/${system_slug}.svg`);
|
||||
const platformCover = await fetch(`https://demo.romm.app/assets/platforms/${info.system_slug}.svg`);
|
||||
|
||||
if (!esPlatform && !rommPlatform)
|
||||
if (!esPlatform && !info.platform)
|
||||
{
|
||||
// go to unknown platform
|
||||
existingPlatform = await tx.query.platforms.findFirst({ where: eq(schema.platforms.slug, "unknown") });
|
||||
|
|
@ -223,14 +174,14 @@ export class InstallJob implements IJob<never, InstallJobStates>
|
|||
{
|
||||
// Create new local platform
|
||||
const platform: typeof schema.platforms.$inferInsert = {
|
||||
slug: rommPlatform?.slug ?? esPlatform?.system.name ?? '',
|
||||
igdb_id: rommPlatform?.igdb_id,
|
||||
igdb_slug: rommPlatform?.igdb_slug,
|
||||
ra_id: rommPlatform?.ra_id,
|
||||
slug: info.platform?.slug ?? esPlatform?.system.name ?? '',
|
||||
igdb_id: info.platform?.igdb_id,
|
||||
igdb_slug: info.platform?.igdb_slug,
|
||||
ra_id: info.platform?.ra_id,
|
||||
cover: Buffer.from(await platformCover.arrayBuffer()),
|
||||
cover_type: platformCover.headers.get('content-type'),
|
||||
name: rommPlatform?.name ?? esPlatform?.system.fullname ?? '',
|
||||
family_name: rommPlatform?.family_name,
|
||||
name: info.platform?.name ?? esPlatform?.system.fullname ?? '',
|
||||
family_name: info.platform?.family_name,
|
||||
es_slug: esPlatform?.system.name ?? undefined
|
||||
};
|
||||
|
||||
|
|
@ -246,38 +197,38 @@ export class InstallJob implements IJob<never, InstallJobStates>
|
|||
|
||||
// create the rom
|
||||
const game: typeof schema.games.$inferInsert = {
|
||||
source_id,
|
||||
source_id: info.source_id,
|
||||
source: this.source,
|
||||
slug,
|
||||
path_fs,
|
||||
last_played: last_played,
|
||||
slug: info.slug,
|
||||
path_fs: info.path_fs,
|
||||
last_played: info.last_played,
|
||||
platform_id: platformId,
|
||||
igdb_id: igdb_id,
|
||||
ra_id: ra_id,
|
||||
summary: summary,
|
||||
name,
|
||||
igdb_id: info.igdb_id,
|
||||
ra_id: info.ra_id,
|
||||
summary: info.summary,
|
||||
name: info.name,
|
||||
cover,
|
||||
cover_type: coverResponse.headers.get('content-type'),
|
||||
metadata
|
||||
metadata: info.metadata
|
||||
};
|
||||
|
||||
const [{ id }] = await tx.insert(schema.games).values(game).returning({ id: schema.games.id });
|
||||
|
||||
if (screenshotUrls.length <= 0 && process.env.TWITCH_CLIENT_ID)
|
||||
if (info.screenshotUrls.length <= 0 && process.env.TWITCH_CLIENT_ID)
|
||||
{
|
||||
const access_token = await secrets.get({ service: 'gamflow_twitch', name: 'access_token' });
|
||||
if (access_token)
|
||||
{
|
||||
const client = igdb.igdb(process.env.TWITCH_CLIENT_ID, access_token);
|
||||
|
||||
const { data } = await client.request('artworks').pipe(igdb.fields(['game', 'url']), igdb.where('game', '=', igdb_id)).execute();
|
||||
const { data } = await client.request('artworks').pipe(igdb.fields(['game', 'url']), igdb.where('game', '=', info.igdb_id)).execute();
|
||||
|
||||
screenshotUrls.push(...data.filter(s => s.url).map(s => s.url!));
|
||||
info.screenshotUrls.push(...data.filter(s => s.url).map(s => s.url!));
|
||||
}
|
||||
}
|
||||
|
||||
// pre-fetch screenshots
|
||||
const screenshots = await Promise.all(screenshotUrls.map(s => fetch(s)));
|
||||
const screenshots = await Promise.all(info.screenshotUrls.map(s => fetch(s)));
|
||||
|
||||
if (screenshots.length > 0)
|
||||
{
|
||||
|
|
@ -300,6 +251,6 @@ export class InstallJob implements IJob<never, InstallJobStates>
|
|||
}
|
||||
|
||||
|
||||
events.emit('notification', { message: `${name}: Installed`, type: 'success', duration: 8000 });
|
||||
events.emit('notification', { message: `${info.name}: Installed`, type: 'success', duration: 8000 });
|
||||
}
|
||||
}
|
||||
|
|
@ -3,9 +3,8 @@ import { IJob, JobContext } from "../task-queue";
|
|||
import { ActiveGameSchema, ActiveGameType } from "@/bun/types/typesc.schema";
|
||||
import { db, events, plugins } from "../app";
|
||||
import * as appSchema from "@schema/app";
|
||||
import { eq } from "drizzle-orm";
|
||||
import { eq, sql } from "drizzle-orm";
|
||||
import { spawn } from 'node:child_process';
|
||||
import { updateRomUserApiRomsIdPropsPut } from '@/clients/romm';
|
||||
|
||||
export class LaunchGameJob implements IJob<z.infer<typeof LaunchGameJob.dataSchema>, "playing">
|
||||
{
|
||||
|
|
@ -38,7 +37,7 @@ export class LaunchGameJob implements IJob<z.infer<typeof LaunchGameJob.dataSche
|
|||
|
||||
const commandArgs = await plugins.hooks.games.emulatorLaunch.promise({
|
||||
autoValidCommand: this.validCommand,
|
||||
game: { source: this.gameSource, sourceId: this.gameSourceId, id: this.gameId }
|
||||
game: { source: this.gameSource, id: this.gameId }
|
||||
});
|
||||
const command = commandArgs ? this.validCommand.metadata.emulatorBin ?? this.validCommand.command : this.validCommand.command;
|
||||
|
||||
|
|
@ -68,19 +67,22 @@ export class LaunchGameJob implements IJob<z.infer<typeof LaunchGameJob.dataSche
|
|||
command: this.validCommand
|
||||
};
|
||||
|
||||
function updateRommProps (id: number)
|
||||
const updatePlayed = async (source: string, id: string) =>
|
||||
{
|
||||
updateRomUserApiRomsIdPropsPut({ path: { id }, body: { update_last_played: true } });
|
||||
events.emit('notification', { message: "Updated Last Played", type: 'success' });
|
||||
}
|
||||
await db.update(appSchema.games).set({ last_played: new Date() }).where(eq(appSchema.games.id, this.gameId));
|
||||
await plugins.hooks.games.updatePlayed.promise({ source, id }).then(v =>
|
||||
{
|
||||
if (v) events.emit('notification', { message: "Updated Last Played", type: 'success' });
|
||||
});
|
||||
};
|
||||
|
||||
if (this.gameSource === 'romm')
|
||||
if (this.gameSource !== 'local')
|
||||
{
|
||||
updateRommProps(Number(this.gameSourceId));
|
||||
updatePlayed(this.gameSource, this.gameSourceId);
|
||||
}
|
||||
else if (localGame?.source === 'romm' && localGame.source_id)
|
||||
else if (localGame?.source && localGame?.source !== 'local' && localGame.source_id)
|
||||
{
|
||||
updateRommProps(Number(localGame.source_id));
|
||||
updatePlayed(localGame.source, localGame.source_id);
|
||||
}
|
||||
});
|
||||
|
||||
|
|
|
|||
|
|
@ -37,7 +37,7 @@ export class LoginJob implements IJob<z.infer<typeof LoginJob.dataSchema>, "base
|
|||
.post(`/login`, async ({ body }) =>
|
||||
{
|
||||
const response = await tryLoginAndSave(body as any);
|
||||
if (response?.code === 200)
|
||||
if (response.response.ok)
|
||||
{
|
||||
context.abort("success");
|
||||
return status("Accepted");
|
||||
|
|
|
|||
|
|
@ -3,6 +3,7 @@ import secrets from "../secrets";
|
|||
import open from "open";
|
||||
import z from "zod";
|
||||
import { delay } from "@/shared/utils";
|
||||
import { plugins } from "../app";
|
||||
|
||||
|
||||
interface TwitchDevice
|
||||
|
|
@ -94,6 +95,8 @@ export default class TwitchLoginJob implements IJob<z.infer<typeof TwitchLoginJo
|
|||
secrets.set({ service: 'gamflow_twitch', name: 'access_token', value: data.access_token });
|
||||
secrets.set({ service: 'gamflow_twitch', name: 'refresh_token', value: data.refresh_token });
|
||||
secrets.set({ service: 'gamflow_twitch', name: 'expires_in', value: new Date(new Date().getTime() + data.expires_in).toString() });
|
||||
|
||||
await plugins.hooks.auth.loginComplete.promise({ service: 'twitch' });
|
||||
break;
|
||||
}
|
||||
else if (res.status !== 400)
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue